Move exception lock to ModuleInstance data.#4772
Move exception lock to ModuleInstance data.#4772lum1n0us merged 3 commits intobytecodealliance:mainfrom
Conversation
lum1n0us
left a comment
There was a problem hiding this comment.
-
The PR has affected the layout of
WASMModuleInstanceExtra, which will change keyoffsetofvalues in AOT files. Therefore, it requires a newAOT_CURRENT_VERSIONin core/config.h. -
Obviously, there is a failed CI that should be fixed.
eca416a to
3bc7eb7
Compare
|
Thank you so much! Fixed both issues, all CI checks are green now. |
906cf84 to
93af779
Compare
This lock acquired on each native function call. This cause performance impact on programs, containing many native function calls, and running in multithreaded environment.
93af779 to
2e07a8c
Compare
2e07a8c to
bdd43c7
Compare
|
Thank you so much for review.
Of course, you, as code owner, know better all nuances. I just write to ensure that we'll not force our users re-compile all their AOT programs without need. |
|
The basic relationship is that PR#4400 was likely overlooked. Currently, the entire review system relies on manual review. Perhaps we could consider introducing other tools to assist. |
This lock acquired on each native function call. This cause performance impact on programs, containing many native function calls, and running in multithreaded environment.